Migrate to Changesets #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's looking like our config will require numerous breaking changes to get to ESLint v8 compatibility (#62). If we stuck with semantic-release we'd either need to get creative with branching, have one mega PR or release a bunch of intermediary major versions that add little value. Instead, switch to Changesets. This is used in a number of our OSS repos and makes it easier to bundle multiple changes into a release. We support previewing the release notes with and without a `GITHUB_TOKEN` via `yarn version`.
72636c
commented
Oct 25, 2021
|
|
||
| - name: Set up Node.js 14.x | ||
| - name: Set up Node.js 16.x |
michaeltaranto
approved these changes
Oct 25, 2021
72636c
added a commit
that referenced
this pull request
Oct 31, 2021
I missed that the release failed in #63: https://github.com/seek-oss/eslint-config-seek/runs/4004599366?check_suite_focus=true#step:5:19
72636c
added a commit
that referenced
this pull request
Nov 2, 2021
I missed that the release failed in #63: https://github.com/seek-oss/eslint-config-seek/runs/4004599366?check_suite_focus=true#step:5:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's looking like our config will require numerous breaking changes to get to ESLint v8 compatibility (#62). If we stuck with semantic-release we'd either need to get creative with branching, have one mega PR or release a bunch of intermediary major versions that add little value.
Instead, switch to Changesets. This is used in a number of our OSS repos and makes it easier to bundle multiple changes into a release. We support previewing the release notes with and without a
GITHUB_TOKENviayarn version.